We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@kotp, I'd like to propose some cleanup.
For starters, I'd like to go through the remaining exercises and fill out the empty file stubs.
(defmodule exercise-slug (export (function-being-tested 1))) ; Please implement the function-being-tested function.
Second, I want to drop the .gitignore files in each exercise since they're largely clutter. We already have a global .gitignore file.
Third, I want to fill out the description for every exercise's src/exercise-slug.app.src file since make test wants this filled out on some LFE versions. https://github.com/exercism/erlang/blob/881e88d00dc42176b046b743f566a40625fbd887/exercises/practice/clock/src/clock.app.src#L2 is an example of how that's filled out on the Erlang track, and we can do something similar like "exercism.org - clock".
src/exercise-slug.app.src
make test
Fourth, the rebar config files are marked as invalidators, but I think the rebar lock and app.src files should be as well.
Fifth, the indent size is set to 4 spaces, but I think this should be set to 2 spaces judging from the LFE code.
Anything else I missed or something I shouldn't do from this initial list?
The text was updated successfully, but these errors were encountered:
.gitignore
"invalidator": [ "rebar.config" ]
rebar.lock
app.src
The Lisp Style Tips for the Beginner is a pretty clear no-nonsense (and less "by consensus, check your editor") reference, I think.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
@kotp, I'd like to propose some cleanup.
For starters, I'd like to go through the remaining exercises and fill out the empty file stubs.
Second, I want to drop the .gitignore files in each exercise since they're largely clutter. We already have a global .gitignore file.
Third, I want to fill out the description for every exercise's
src/exercise-slug.app.src
file sincemake test
wants this filled out on some LFE versions. https://github.com/exercism/erlang/blob/881e88d00dc42176b046b743f566a40625fbd887/exercises/practice/clock/src/clock.app.src#L2 is an example of how that's filled out on the Erlang track, and we can do something similar like "exercism.org - clock".Fourth, the rebar config files are marked as invalidators, but I think the rebar lock and app.src files should be as well.
Fifth, the indent size is set to 4 spaces, but I think this should be set to 2 spaces judging from the LFE code.
Anything else I missed or something I shouldn't do from this initial list?
The text was updated successfully, but these errors were encountered: