Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grade-school: update test suite and version file to 1.0.0 #174

Closed
sjwarner-bp opened this issue Jun 8, 2018 · 2 comments
Closed

grade-school: update test suite and version file to 1.0.0 #174

sjwarner-bp opened this issue Jun 8, 2018 · 2 comments

Comments

@sjwarner-bp
Copy link
Contributor

sjwarner-bp commented Jun 8, 2018 •
edited
Loading

Please add a version file exercises/grade-school/.meta/version with the string 1.0.0 for the series exercise.

Since implementing this exercise, canonical-data has been added for series in the problem-specifications repo. In order ensure our tests cover all cases and are consistent with other tracks, we should try to mirror problem-specifications as closely as possible.

Because of this, the test suite should be rewritten to comply with version 1.0.0.

Additionally, the reference implementation will need updating to pass the new test suite.
@sup95
Copy link
Contributor

sup95 commented Oct 2, 2018

I'd like to work on this. :)

@dector dector added the issue: ready for dev Issue is ready for development. label Nov 11, 2019
@eparovyshnaya
Copy link
Contributor

done by PR 390

@eparovyshnaya eparovyshnaya mentioned this issue Jan 10, 2020
Merged
@eparovyshnaya eparovyshnaya removed the issue: ready for dev Issue is ready for development. label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dector @eparovyshnaya @sup95 @sjwarner-bp