Convert to ESLint 9 flat config and move to pnpm, use .mjs and new jest types #2548
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SleeplessByte
added
hacktoberfest-accepted
|
Okay. So. This PR works and relies on exercism/javascript-test-runner#852, but I do not know if that PR will work as it requires the My plan is:
If that works, mark this as ready and we are good to go! If it doesn't work, I will revert the test runner and message Jeremy. |
|
What a monster PR! Not even sure where to start with this... |
|
Isn't it fun 📦. Basically: eslint 9, pnpm instead of npm. Check that the instructions to install are clear and that you don't absolutely hate it. |
|
Looks good from what I could see, appart from a few leftover comments. |
|
@Cool-Katt where's the comments? |
| * Run this script (from root directory): npx babel-node scripts/sync | ||
| * Run this script (from root directory): | ||
| * | ||
| * $ corepack yarn sync |
There was a problem hiding this comment.
Shouldn't it be pnpm here instead of yarn?
| #!/usr/bin/env node | ||
|
|
||
| /** | ||
| * Run this script (from root directory): npx babel-node scripts/checksum |
| @@ -7,5 +7,6 @@ | |||
| // because of how whitespace is (not) rendered. | |||
| 65 | |||
| ] | |||
| } | |||
| }, | |||
| "cSpell.words": ["xtest"] | |||
There was a problem hiding this comment.
is this intended for here or was it an artifact?
There was a problem hiding this comment.
Eh. Yeah i run spellcheck locally but didn't mean to commit this I think.
|
@SleeplessByte sorry, I accidentally forgot to post the actual review. Lol |
Related: exercism/javascript-test-runner#852
Similar to: exercism/typescript#1506
corepackgets removed in the future, our migration path is as "simple" as removingcorepackfrom the calls. Everything keeps working.