-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated hints.md for fruit picker exercise #1973
updated hints.md for fruit picker exercise #1973
Conversation
Dear triangletrianglesquareplusxThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
Thank you!
We generally rebase on a freshly updated |
/format |
Closing and re-opening to re-trigger CI |
Good work! I found this because I noticed the hints were outdated and this is a big improvement. |
@neenjaw wanna have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement here 🎉 I have some thoughts to iterate on your improvements.
Generally I think we could refocus the student to pay attention to the hints already in the file -- the JSDoc comments and the stubbed function signatures.
What do you think?
I also think we could update the title of each step in the instructions to match the names of each step in the hints; once we settle on their wording
@triangletrianglesquareplusx would you still like to apply some if not all of the suggestions given in the review? |
Hey @SleeplessByte is this still active/needed - I had my pc stolen with my credentials and it was a nightmare to get stuff back. |
@triangletrianglesquareplusx yes please!! |
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
Co-authored-by: Tim Austin <[email protected]>
All the suggestions applied. Had to use GUI here, did not manage to push from local branch via terminal and thus all of the resolved/non resolved stuff you might be seeing. Hopefully everything else is fine @SleeplessByte |
Hello, this related to #1833. Updated hints.md and tried to be more exact. Please let me know if you dislike anything, I really like your project and want to help more.
PS. I have been taught that it is a good idea to first merge main into whatever my branch is and THEN do the pull request at the end. Do you like doing that as well?