Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated hints.md for fruit picker exercise #1973

Conversation

triangletrianglesquareplusx
Copy link
Contributor

Hello, this related to #1833. Updated hints.md and tried to be more exact. Please let me know if you dislike anything, I really like your project and want to help more.

PS. I have been taught that it is a good idea to first merge main into whatever my branch is and THEN do the pull request at the end. Do you like doing that as well?

@github-actions
Copy link
Contributor

Dear triangletrianglesquareplusx

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@SleeplessByte
Copy link
Member

Thank you!

PS. I have been taught that it is a good idea to first merge main into whatever my branch is and THEN do the pull request at the end. Do you like doing that as well?

We generally rebase on a freshly updated main, and then make the PR, but it's all fine.

@SleeplessByte
Copy link
Member

/format

@SleeplessByte
Copy link
Member

Closing and re-opening to re-trigger CI

@devjusty
Copy link

Good work! I found this because I noticed the hints were outdated and this is a big improvement.

@SleeplessByte
Copy link
Member

@neenjaw wanna have a look at this?

Copy link
Contributor

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement here 🎉 I have some thoughts to iterate on your improvements.

Generally I think we could refocus the student to pay attention to the hints already in the file -- the JSDoc comments and the stubbed function signatures.

What do you think?


I also think we could update the title of each step in the instructions to match the names of each step in the hints; once we settle on their wording

exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/hints.md Outdated Show resolved Hide resolved
@SleeplessByte
Copy link
Member

@triangletrianglesquareplusx would you still like to apply some if not all of the suggestions given in the review?

@triangletrianglesquareplusx
Copy link
Contributor Author

triangletrianglesquareplusx commented Aug 15, 2023

Hey @SleeplessByte is this still active/needed - I had my pc stolen with my credentials and it was a nightmare to get stuff back.

@SleeplessByte
Copy link
Member

@triangletrianglesquareplusx yes please!!

@triangletrianglesquareplusx
Copy link
Contributor Author

All the suggestions applied. Had to use GUI here, did not manage to push from local branch via terminal and thus all of the resolved/non resolved stuff you might be seeing. Hopefully everything else is fine @SleeplessByte

@SleeplessByte SleeplessByte merged commit 911785a into exercism:main Aug 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants