Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability warnings due to outdated package-lock.json #700

Closed
KillyMXI opened this issue Jul 24, 2019 · 5 comments
Closed

Vulnerability warnings due to outdated package-lock.json #700

KillyMXI opened this issue Jul 24, 2019 · 5 comments

Comments

@KillyMXI
Copy link

KillyMXI commented Jul 24, 2019

Used the exercism download --exercise=dnd-character --track=javascript command to get the dnd-character exercise.
After executing npm i I got a counter of vulnerabilities at several thousands.
NPM Audit shows it is all about a single library somewhere deep in the dependencies that was fixed already.

This particular lock file should be regenerated.
And isn't there any planned/automated audit checks to prevent an accumulation of issues like this?

@SleeplessByte
Copy link
Member

image

These are automated and come in regularly.
https://github.com/exercism/javascript/blob/master/scripts/sync syncs the package.json. However, we (iirc) do NOT provide a package-lock.json for the exercise-level. That means that the initial install (the one you do when you pull the exercise) might not actually have the fixes until you run the audit.

In short: you'll see the warnings unless you run audit fix, or when ⬆️ upstream is fixed.

@tejasbubane
Copy link
Member

This should be fixed by #702.

@SleeplessByte
Copy link
Member

It still leaves the issue with npm and locks.

@KillyMXI
Copy link
Author

No package versions update were needed to remove the warning - it was addressed in patch versions of related packages already.
It was enough to manually remove lock file and node_modules, then reinstall to clear the warning.

Just checked. 15834 high severity vulnerabilities still reported on fresh install.
If you have another housekeeping routine to update package-lock.json files - that will actually remove the issue.

@tejasbubane
Copy link
Member

Created #703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants