Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Luhn tests #260

Closed
IanWhitney opened this issue Jan 11, 2017 · 1 comment
Closed

Changes to Luhn tests #260

IanWhitney opened this issue Jan 11, 2017 · 1 comment

Comments

@IanWhitney
Copy link

We recently rewrote the test suite for the Luhn exercise. Since this track implements Luhn, please take a look at the new canonical_data.json file and see if your track should update its implementation or tests.

Details on the test changes and the motivation can be found in the PR.

Tracking of these changes is being done at the tracking issue.

@rchavarria
Copy link
Contributor

(same as xjavascript)

I fear the specs here are quite different from the canonical data and we should reimplement both specs and example implementation 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants