Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary: improve tests for invalid numbers #109

Closed
kytrinyx opened this issue Apr 7, 2016 · 3 comments
Closed

binary: improve tests for invalid numbers #109

kytrinyx opened this issue Apr 7, 2016 · 3 comments

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Apr 7, 2016

We should have separate tests for:

  • alphabetic characters at the beginning of a valid binary number
  • alphabetic characters at the end of a valid binary number
  • alphabetic characters in the middle of an otherwise valid binary number
  • invalid digits (e.g. 2)

If the test suite for binary has test cases that cover these edge cases, this issue can safely be closed.

See exercism/problem-specifications#95

@matthewmorgan
Copy link
Contributor

This track is missing a few of the above mentioned tests. It does have a test that puts alphabetic characters at the beginning AND end of the input (in the same single test). To make it complete we should add:

  • alphabetic characters at the beginning of a valid binary number
  • alphabetic characters at the end of a valid binary number
  • alphabetic characters in the middle of an otherwise valid binary number

@kytrinyx
Copy link
Member Author

kytrinyx commented Apr 7, 2016

Yeah, you could probably split the existing test into two tests (I think if you have one for the beginning and one for the end, a test for both beginning and end is redundant).

@kytrinyx
Copy link
Member Author

I'm going to go ahead and close this, due to exercism/problem-specifications#279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants