Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exercises with latest canonical data #488

Closed
robkeim opened this issue Nov 12, 2017 · 2 comments
Closed

Update exercises with latest canonical data #488

robkeim opened this issue Nov 12, 2017 · 2 comments

Comments

@robkeim
Copy link
Contributor

robkeim commented Nov 12, 2017

I started the first batch of this work in #487 but there are still three exercises remaining (as of Nov 12):

  • AllYourBase (changed to using "error" structure)
  • BeerSong (changed to returning an array which isn't currently being formatted multi-line. That means the test validating the entire song is a reaaalllllyyyyy long line :) I think we should update the array to be able to be formatted multiline)
  • NthPrime (changed to using "error" structure)

@ErikSchierboom FYI
@robkeim robkeim mentioned this issue Nov 12, 2017
Merged
@ErikSchierboom
Copy link
Member

I'm working on this

@ErikSchierboom ErikSchierboom mentioned this issue Nov 13, 2017
Merged
@ErikSchierboom
Copy link
Member

@robkeim PR #492 doesn't include the BeerSong update, which I've included in a new issue: #493.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ErikSchierboom @robkeim