Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in robot-simulator test. #762

Closed
JKilgallen opened this issue Nov 4, 2023 · 2 comments
Closed

Typo in robot-simulator test. #762

JKilgallen opened this issue Nov 4, 2023 · 2 comments

Comments

@JKilgallen
Copy link
Contributor

Sorry if opening an issue for this is unnecessary (this is my first time ever opening one).

I noticed a couple of typos in the robot-simulator test suite.
In line 102 of robot-simulator-test.lisp it reads
advance-decrements-y-when-facing-north
when I believe it should be (based on the test)
advance-decrements-y-when-facing-south
Additionally, line 126 reads
move-east-and-north-readme
when I think it should just be
move-east-and-north
in line with the rest of the tests.

Would anyone mind if I made the changes and did a pull request? (my first on an open-source project)

Copy link

github-actions bot commented Nov 4, 2023

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

@github-actions github-actions bot closed this as completed Nov 4, 2023
@verdammelt verdammelt reopened this Nov 4, 2023
@verdammelt
Copy link
Member

@JKilgallen Thanks for catching these.

Do you want to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants