Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run exercise tests through Travis #104

Closed
sjwarner-bp opened this issue Dec 26, 2017 · 5 comments
Closed

Run exercise tests through Travis #104

sjwarner-bp opened this issue Dec 26, 2017 · 5 comments
Assignees
@budmc29 @Smarticles101
Labels
ci discussion enhancement

Comments

@sjwarner-bp
Copy link
Contributor

sjwarner-bp commented Dec 26, 2017 •
edited
Loading

As mentioned in #4, for each pull request, a run through all exercise tests would help maintainers quickly identify if the submission causes the tests to fail.

Travis is currently used to lint submissions. <- incorrect! configlet lint is pulled in, but #116 talks about code linting.
@sjwarner-bp
Copy link
Contributor Author

I personally have little experience in Travis, but am more than happy to look in to this if no-one else has experience - let me know 👍

@Smarticles101
Copy link
Member

I've got some experience with Travis. I might be able to work on this if I have time.

@sjwarner-bp
Copy link
Contributor Author

sjwarner-bp commented Dec 27, 2017 •
edited
Loading

Sounds good to me @Smarticles101 🙂

@budmc29 budmc29 mentioned this issue Jan 2, 2018
Closed
@budmc29
Copy link
Member

budmc29 commented Jan 4, 2018

@Smarticles101 any updates on this? If you are too busy I can give it a try this weekend.

@budmc29 budmc29 mentioned this issue Jan 8, 2018
Merged
@sjwarner-bp sjwarner-bp mentioned this issue Jan 8, 2018
Merged
@budmc29 budmc29 self-assigned this Jan 8, 2018
@budmc29 budmc29 mentioned this issue Jan 9, 2018
Merged
@sjwarner-bp
Copy link
Contributor Author

Fixed via #148 (Thanks! 🙂 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budmc29 budmc29

@Smarticles101 Smarticles101

Labels
ci discussion enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@budmc29 @Smarticles101 @sjwarner-bp