Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in tooltip text of launchers #722

Closed
rhugonnet opened this issue Apr 14, 2023 · 1 comment · Fixed by #831
Closed

Typo in tooltip text of launchers #722

rhugonnet opened this issue Apr 14, 2023 · 1 comment · Fixed by #831

Comments

@rhugonnet
Copy link

Hi all,

First, thanks for the amazing work on this theme! 🙂

Just noticed a very minor issue while hovering over the Binder launcher, there is a space missing in the tooltip, it shows as: Launch onBinder

Looks like this needs to be corrected for all launcher types:

"tooltip": translation("Launch on") + "Binder",

"tooltip": translation("Launch on") + "JupyterHub",

"tooltip": translation("Launch on") + "Colab",

"tooltip": translation("Launch on") + "Deepnote",

Or maybe I don't fully get the behaviour of sphinx.locale.get_translation?
Happy to open a PR if that saves time.

On another topic: Any update/plan to work on #282? I'm also very interested in that feature, could potentially contribute if nothing is ongoing already.

@welcome
Copy link

welcome bot commented Apr 14, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant