Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put uncompiled assets in translations in a proper directory adhering to sphinx-theme-builder #475

Closed
Tracked by #649
AakashGfude opened this issue Feb 2, 2022 · 0 comments · Fixed by #480
Closed
Tracked by #649

Comments

@AakashGfude
Copy link
Member

I think we could just put it under theme/sphinx_book_theme/translations

@choldgraf since we are compiling jsons to *.mo files, and sphinx-theme-builder technically encourages any assets that need to be compiled to be put in src/sphinx_book_theme/assets, so I am a bit confused https://sphinx-theme-builder.readthedocs.io/en/latest/reference/filesystem-layout/. Also, I think we should add the creation of *.mo files in webpack instead of committing them?

Originally posted by @AakashGfude in #469 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant