Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump click dependency #424

Closed
2 tasks
rdbisme opened this issue Nov 2, 2021 · 6 comments
Closed
2 tasks

Bump click dependency #424

rdbisme opened this issue Nov 2, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@rdbisme
Copy link

rdbisme commented Nov 2, 2021

Description / Summary

Click 7.x is not supported anymore and I'm hitting a problem with that version. Would it be possible to bump or unpin the dep on click?

Value / benefit

  • This will allow to depend on more recent versions of click

Implementation details

No response

Tasks to complete

  • Bump version in setup.py
  • Make sure that tests still work
@rdbisme rdbisme added the enhancement New feature or request label Nov 2, 2021
@welcome
Copy link

welcome bot commented Nov 2, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@rdbisme rdbisme changed the title Bump click dep Bump click dependency Nov 2, 2021
@chrisjsewell
Copy link
Member

Heya, yep I'm already aware of click v8. It should be a problem to update, but needs to be synchronised with an update in other packages, including jupyter-book and sphinx-external-toc

@rdbisme
Copy link
Author

rdbisme commented Nov 11, 2021

Ehi @chrisjsewell, thanks. Maybe just unpinning it allowing also future versions? If the code still works with 8.x, that would let other project their time to adapt, still allowing people needing more modern versions to use them, wouldn't it?

@rdbisme
Copy link
Author

rdbisme commented Nov 11, 2021

Also, why is explicitly listed? I fasly searched here on Github and click does not seem to be used in this project, isn't it?

@choldgraf
Copy link
Member

I was wondering the same thing - is there a reason that we're depending on click in the book theme? I would have imagined this is only necessary for the command-line-based tools.

If we can't think of a good reason, I'm +1 on removing Click as a dependency

@choldgraf
Copy link
Member

this was closed in #457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants