-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 MAINTAIN: Add mypy type-checking #64
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 95.69% 95.75% +0.06%
==========================================
Files 78 78
Lines 3970 3984 +14
==========================================
+ Hits 3799 3815 +16
+ Misses 171 169 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
raise NotImplementedError | ||
# if "\\" in string: | ||
# return string | ||
# return string.replace(UNESCAPE_MD_RE, "$1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simply commented this function out, because str.replace()
takes strings as input, not re.Patterns, so this is probably broken.
I will get round to looking at this eventually! Just want to make sure I look thoroughly, since its touching core code |
I rebased on master, and added one more commit that adds |
👍
TBH it would be so much nicer and concise if you could use the typescript def func(a: Employee? = None):
pass |
I think I've seen some discussion around that |
Oh thats nice 😄 Yeh for typing, I think they should just copy everything from typescript, which they are basically gradually doing |
Haha yeh seems so. Btw. the new union syntax obviously lets us do |
5b52420
to
4919281
Compare
Closes #19