Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOC: document available bib styles #845

Merged
merged 4 commits into from
Aug 4, 2020

Conversation

emdupre
Copy link
Collaborator

@emdupre emdupre commented Aug 4, 2020

Closes #838.

Right now I'm only pointing to other available styles, rather than providing an example of each.
I realized it might be a bit overwhelming to show all four possible styles in one place, but I'm happy to add this in if folks think it would be useful !

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #845 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #845   +/-   ##
=======================================
  Coverage   84.88%   84.88%           
=======================================
  Files           8        8           
  Lines         668      668           
=======================================
  Hits          567      567           
  Misses        101      101           
Flag Coverage Δ
#pytests 84.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70b22f...e508bc8. Read the comment docs.

@choldgraf
Copy link
Collaborator

this looks great! do you think you could add it as a subsection underneath the current one? So a ### header that comes just before the cross-referencing section?

@emdupre emdupre force-pushed the doc/bib-sty branch 2 times, most recently from d4e038d to 59c3005 Compare August 4, 2020 01:43
@emdupre
Copy link
Collaborator Author

emdupre commented Aug 4, 2020

GitHub is really calling me out my workflow of commit, push, and immediately notice a typo 😅

I think that's the last of them, though ! Let me know what you think of the current format !

@choldgraf
Copy link
Collaborator

this looks great! thanks for the improvement :-)

@choldgraf choldgraf changed the title [doc] document available bib styles 📚 DOC: document available bib styles Aug 4, 2020
@choldgraf choldgraf merged commit 143f57a into jupyter-book:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document changing bibliography style
2 participants