Use CDNs for JS libraries #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses CDNs to serve five JS libraries that are currently
checked into this repo:
anchor.min.js
lunr/lunr.min.js
print.min.js
tocbot.min.js
turbolinks.js
The corresponding copies of these libraries in this repo are removed.
It's considered good practice to use CDNs to serve minified JS files
since CDNs are designed to serve static files fast.
This doesn't change page load time for me, but might have benefits for
people located outside California (where there are fewer GitHub
servers and more Cloudflare servers).
SamLau95
force-pushed
the
async-everything
branch
from
ef56ddd
to
d49b87f
Compare
|
Interesting! I had made the assumption that it's be better / faster to load these locally instead of from a CDN. Thanks for clarifying here! |
Since these scripts are loaded asynchronously now, we need to ensure that the libraries are loaded before trying to initialize them.
|
Is this ready to go? |
|
Yup, this is good to go. |
|
Then thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses CDNs to serve five JS libraries that are currently
checked into this repo:
The corresponding copies of these libraries in this repo are removed.
It's considered good practice to use CDNs to serve minified JS files
since CDNs are designed to serve static files fast.
This doesn't change page load time for me, but might have benefits for
people located outside California (where there are fewer GitHub
servers and more Cloudflare servers).