-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding jupytext support #280
Conversation
131f223
to
d69fcf8
Compare
d69fcf8
to
306736a
Compare
Awesome - I love this! It will become so easy to convert pre-existing Markdown books to a Jupyter Book! I will contribute two very minor comments to the code, and answer your question on how to identify if the file did contain metadata. @choldgraf , may I ask you two more questions:
|
|
||
Right now, this just tries to guess based on whether there's a particular piece of | ||
metadata in the notebook. Not sure if this is actually correct though... | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to test that the metadata notebook_metadata_filter
is -all
. I will explain this with a bit more detail at mwouts/jupytext#320
OK I think I addressed the two suggestions that you gave, thanks for that guidance! The one thing I'm still not sure on is how to handle multiple files with the same name but different extensions. Right now, it'll loop through these file extensions and stop once it hits an extension that exists in the file system: What do you think about that? The reason I'm preferring ipynb is because this will allow the book to be built without re-running the code each time (AKA, we can cache the outputs). I think that it's probably OK to leave this open as an issue to tackle in the future once more people have had a chance to play around with it. What do you think? |
853abaf
to
d5b1551
Compare
d5b1551
to
c09d125
Compare
Thanks Chris for being so receptive! I'm glad I could help. By the way, I do agree with your choice to give precedence to |
Cool! I'm gonna merge this one then, and give folks a chance to play around with it a bit before we make it official in a release :-) |
Oh sure... I'm going to try this very soon!! Thanks Chris. |
This adds support for using Jupytext to build/run markdown files. This would
let people store a notebook of content as a text file which makes it much
easier to collaborate on and diff.
Two main changes:
md
files are now converted to in-memory notebooks before converting to HTML. This will also standardize what pages look like.md
file that is a Jupytext format will be run before being converted to HTML.cc @mwouts in case he's got ideas for how this could be done better! (though it was awesomely easy with the Python interface :-) )