Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hiding topbar w/ scroll #276

Merged
merged 6 commits into from
Aug 27, 2019
Merged

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Aug 27, 2019

This factors out part of #169 into just the navbar at the top so that we can iterate step-by-step.

This PR does a general refactor of the page layout in order to try and make it a bit more modular, so that at a top-level it's clear where each thing is spaced it. It also uses this as an opportunity to refactor the top-level bar so that it takes up less whitespace, has its own div for the buttons, and shows itself if you scroll up from down on the page. Finally, this also re-implements the "sidebar popout" functionality we saw before where you can write notes in the margins.

Topbar notes

All of the top bar buttons (toggle sidebar + the interact buttons) live in their own div. This will hide itself on scroll down, and show itself on scroll up. This means you can re-show these buttons from anywhere on the page if you like. Just scroll up.

General layout notes

This shouldn't change the general look and feel of the page, but things should just feel a little bit tighter now. The biggest difference currently is that the screen width is much wider, not sure if we want to keep that or not. Finally, tags will now automatically be added as classes to code and markdown cells. Any tag will be added as a class with the structure tag_{{ tagname }}.

@choldgraf choldgraf added the enhancement New feature or request label Aug 27, 2019
@choldgraf choldgraf changed the title Topbar Add a hiding topbar w/ scroll Aug 27, 2019
@choldgraf choldgraf merged commit 29bac6c into jupyter-book:master Aug 27, 2019
@choldgraf choldgraf deleted the topbar branch August 27, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant