Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use celltagpreprocessor to remove parts of cells and updating running code module #264

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

choldgraf
Copy link
Collaborator

This PR does a few things:

  • Removes the use of a custom template for removing inputs/outputs/etc because we discovered the nbconvert "TagRemovePreprocessor"
  • Fixes up the "run a notebook" code to use the ExecutePreprocessor
  • Uses the RegExpRemovePreprocessor for removing empty cells
  • As a result, we no longer need nbclean so we're removing that dependency (which is actually pretty heavy)
  • One side effect is that stderr will now show up in the output, though we can take that out later pretty easily

@choldgraf choldgraf changed the title updating cell tags and running code module use celltagpreprocessor to remove parts of cells and updating running code module Aug 20, 2019
@choldgraf choldgraf merged commit eaa6927 into jupyter-book:master Aug 20, 2019
@choldgraf choldgraf deleted the celltags branch August 20, 2019 01:52
@choldgraf
Copy link
Collaborator Author

Merging this because I don't think it changes the behavior of the tool at all, it's all under-the-hood simplification

@choldgraf choldgraf added the enhancement New feature or request label Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant