Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing custom TOC code #178

Merged
merged 1 commit into from
Apr 15, 2019
Merged

removing custom TOC code #178

merged 1 commit into from
Apr 15, 2019

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Apr 13, 2019

This doesn't aesthetically change anything from the user's perspective, it does 1 thing:

The reasons to do this are basically:

  1. It removes a complex thing that we can't easily update/modify, and replaces it with a lightweight open source tool
  2. The other tool could be used without the Jekyll machinery, e.g. if we want to easily generate single-page outputs without relying on Jekyll

@choldgraf
Copy link
Collaborator Author

The demo to confirm it looks the same: https://994-137292803-gh.circle-artifacts.com/0/html/intro.html

Copy link
Contributor

@jasmainak jasmainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@choldgraf
Copy link
Collaborator Author

anybody else take issue w/ this approach? @emdupre do you see any downside?

Copy link
Collaborator

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any downsides ! Less of a reliance on Jekyll is a good thing, in my book ✨
And it looks like we don't need to update the dependencies, either, so this is golden IMHO

@choldgraf
Copy link
Collaborator Author

ok! let's give it a whirl! then I bet we can drastically simplify the "single document" mode

@choldgraf choldgraf merged commit db7d7d6 into jupyter-book:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants