Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: right-side navbar auto-scroll #24

Closed
jmason86 opened this issue Aug 21, 2018 · 8 comments · Fixed by #54
Closed

Feature request: right-side navbar auto-scroll #24

jmason86 opened this issue Aug 21, 2018 · 8 comments · Fixed by #54

Comments

@jmason86
Copy link
Contributor

It'd be super nice if the auto-generated nav bar on the right-side scrolled down with the page. Probably should be an optional thing that could be set in the _config.yml.

Having so much fun with this thing! It looks great!
@choldgraf
Copy link
Collaborator

totally agree! to be clear: what you'd like is to have that sidebar stay in place when you scrolled down, so it's always visible?

@jmason86
Copy link
Contributor Author

Yeah -- either just like the left side nav panel or as a floating UI element kind of thing.

@choldgraf
Copy link
Collaborator

definitely agree there :-) I spent a while fiddling with that a while back, but had a hard time getting things to position properly. Will ping this issue if/when I get it figured out! Or PRs are always welcome as well :-)

@jmason86
Copy link
Contributor Author

Sweet thanks! I may take a look at it too as I get more familiar.

@TomDonoghue
Copy link
Contributor

+1 on fixing the right side bar to move with scroll. @ReventonC who works with me on my class is looking into a couple styling things like this, and so we can maybe PR it if we figure it out.

@ReventonC
Copy link
Contributor

ReventonC commented Oct 28, 2018 •
edited
Loading

I moved the {% include onthispage.html ... } to under the <body> tag directly instead of having it under <main> tag, and change the position to fixed, top and right to some value. I think this might be a simple way to implement this feature. You can check my version from here: https://github.com/COGS18/COGS18.github.io/blob/new_site/_sass/components/_components.textbook__sidebar-right.css
One problem is that the default scrolling bar looks bad on it, so I'm currently finding a way to improve it.

@choldgraf
Copy link
Collaborator

@ReventonC did you guys ever figure out a way to make the sidebar stay on the page during scroll? Would love to see the results!

@ReventonC
Copy link
Contributor

Yes! I can make a pull request of this now,

@ReventonC ReventonC mentioned this issue Nov 25, 2018
Merged
@SiccarPoint SiccarPoint mentioned this issue Apr 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the sidebar stay on the page during scroll ReventonC/jupyter-book
4 participants
@jmason86 @choldgraf @ReventonC @TomDonoghue