Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cell pre-wrap causes split lines #182

Closed
choldgraf opened this issue Apr 17, 2019 · 2 comments · Fixed by #188
Closed

Code cell pre-wrap causes split lines #182

choldgraf opened this issue Apr 17, 2019 · 2 comments · Fixed by #188
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@choldgraf
Copy link
Collaborator

I believe that in #180 we told code cells to wrap around. Looking at the result, I'm not sure this is what we want. E.g.:

image

To me this is a bit confusing where the line breaks are - I feel like for code cells, we'd actually like overflow-x to be auto instead of wrapping the content.

What do folks think? In particular @alexmorley who worked on that other patch!

@alexmorley
Copy link
Contributor

Yeah. That is a good point. With syntax highlighting it's usually obvious but I would be totally happy with having the scroll behaviour. The bug I was trying to fix was that the scroll behaviour wasn't applied when nolanguage was set for the code cell.

@choldgraf
Copy link
Collaborator Author

yeah - I agree that was a good bug to fix, I think that it'd be a better default to have horizontal scrolling rather than wrapping for code, just to clear up the confusion.

@choldgraf choldgraf added bug Something isn't working good first issue Good for newcomers labels Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants