Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page turn link URLs missing .html #140

Closed
BENR0 opened this issue Mar 19, 2019 · 2 comments · Fixed by #241
Closed

Page turn link URLs missing .html #140

BENR0 opened this issue Mar 19, 2019 · 2 comments · Fixed by #241
Labels
bug Something isn't working
Milestone

Comments

@BENR0
Copy link

BENR0 commented Mar 19, 2019

The page turn links at the bottom of the page are missing the .html extension. As long as the book is deployed over github pages everything works fine but in our case we want to deploy the site on our own CMS and then the links don't work.

Any help would be appreciated.

@choldgraf
Copy link
Collaborator

ah darn - I would have thought this would work on CMS other than gh-pages...do you have a link where the broken links exist? Otherwise I think we could get around with this a small update to the build script.

@choldgraf choldgraf added this to the v0.5 milestone Apr 7, 2019
@alexmorley
Copy link
Contributor

FWIW this still works on netlify without changes.

@choldgraf choldgraf added the bug Something isn't working label May 2, 2019
@choldgraf choldgraf modified the milestones: v0.5, v0.6 May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants