Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Field Safety and Debugging #208

Open
bevanwsjones opened this issue Dec 18, 2024 · 1 comment
Open

Improve Field Safety and Debugging #208

bevanwsjones opened this issue Dec 18, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers needs-more-info This issue needs some more information vote
Milestone
0.2 Release

Comments

@bevanwsjones
Copy link
Collaborator

bevanwsjones commented Dec 18, 2024 •
edited
Loading

Currently, there are too many ways to shoot yourself in the foot with accessors, etc, between CPU/GPU. This needs to be improved for quality of life.
@bevanwsjones bevanwsjones added this to the 0.2 Release milestone Dec 18, 2024
@bevanwsjones bevanwsjones added enhancement New feature or request good first issue Good for newcomers labels Dec 18, 2024
@bevanwsjones bevanwsjones changed the title Imporve Field Safety and Debugging Improve Field Safety and Debugging Dec 18, 2024
@greole
Copy link
Contributor

greole commented Dec 19, 2024 •
edited
Loading

Some options from our discussion:

  1. remove operator[] and rely on span 👍
  2. add some assert statement to operator[] 🎉
  3. mirroring ie having a dirty copy on host 🚀

@greole greole added vote needs-more-info This issue needs some more information labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers needs-more-info This issue needs some more information vote
Projects
Prototype implementation of NeoFOAM
Status: Backlog
Milestone
0.2 Release
Development

No branches or pull requests
2 participants
@greole @bevanwsjones