Try building on windows #154

Fitanium · 2024-10-04T16:05:02Z

In this PR I made some changes to NeoFOAM so that it can be built on Windows.

My hardware configuration:

OS: Windows 11 Pro
Compiler: Microsoft (R) C/C++ Optimizing Compiler Version 19.38.33130
CUDA: 12.1 (GeForce 2060 12GB)
MPI: MS-MPI 10.1.12498.52

CMake command line:

cd /path/to/NeoFOAM
mkdir build
cd build 
cmake .. -DCMAKE_BUILD_TYPE=Release -DKokkos_DIR="D:/dev/Kokkos/lib/cmake/Kokkos"

Build with MS-Build:

MSBuild.exe -p:configuration=Release -p:platform=x64 -m:8 .\NeoFOAM.sln

The following is screenshot of some logs:

Hope this helps.

…on was made to 'demangle' function

…iles as CUDA source files

…annot be referenced -- it is a deleted function

…nt function ('CATCH2_INTERNAL_TEST_0') for an extended __host__ __device__ lambda cannot have internal or no linkage

Fitanium · 2024-10-06T09:57:54Z

CMake config:

Build:

MSBuild.exe -p:configuration=Release -p:platform=x64 -noLogo -m .\NeoFOAM.sln

Generated files:

greole · 2024-10-06T14:16:50Z

I created a branch/PR to add enable building NeoFOAM without mpi support, see #156. Once, that is ready we should add windows support without mpi first.

greole

Just a quick and not complete review. Looks already in good shape, thank you!
Two general comments:

Please move the additional benchmarking and non windows build related changes to a separate PR. This helps to keep the PRs easy to review.
Please remove the MPI related changes, since we try to add support for builds without MPI first.

CMakeLists.txt

benchmarks/fields/bench_fields.cpp

cmake/CxxThirdParty.cmake

cmake/Docs.cmake

include/NeoFOAM/core/mpi/operators.hpp

src/CMakeLists.txt

src/core/demangle.cpp

test/core/parallelAlgorithms.cpp

…indows

…ing parent function ('CATCH2_INTERNAL_TEST_0') for an extended __host__ __device__ lambda cannot have internal or no linkage" This reverts commit cf84406.

CMakeLists.txt

src/CMakeLists.txt

…l depend the configuration of Kokkos if found

cmake/AutoEnableDevice.cmake

Fitanium added 8 commits October 4, 2024 23:30

Don't need to specify MPI version

23cd73c

MS-MPI support only MPI_C_XXX for bool and complex

513b0b5

also link MPI_C library

36a0eb6

cxxabi.h is only available for GNU C, not MSVC, some minor modificati…

faa0e6c

…on was made to 'demangle' function

Build with NVCC, need to define macro __CUDACC__, so set the source f…

7b2e475

…iles as CUDA source files

check mpi-test

bc7d12e

update CMakeLists.txt

1fe1596

formating

54ee960

greole linked an issue Oct 4, 2024 that may be closed by this pull request

Windows build #137

Open

Fitanium added 9 commits October 5, 2024 10:41

fix doc build macro

b21c355

update benchmarks CMakeLists.txt

40a51d9

FindCUDAToolkit when Kokkos_ENABLE_CUDA=ON

eb22bad

minor modification

888bc2d

minor modification

53d666c

add static lib for test

f771ffe

update MPI TYPE

c133050

change to avoid MSVC compile error message: the default constructor c…

01e15e6

…annot be referenced -- it is a deleted function

change to avoid compile error message: On Windows, the enclosing pare…

cf84406

…nt function ('CATCH2_INTERNAL_TEST_0') for an extended __host__ __device__ lambda cannot have internal or no linkage

greole changed the base branch from main to feat/nompi October 6, 2024 14:58

greole changed the base branch from feat/nompi to main October 6, 2024 14:58

greole requested changes Oct 6, 2024

View reviewed changes

greole changed the base branch from main to ci/win October 7, 2024 06:57

greole force-pushed the ci/win branch 2 times, most recently from cebb577 to 1088d50 Compare October 8, 2024 18:53

Fitanium added 4 commits October 9, 2024 23:04

Merge remote-tracking branch 'upstream/ci/win' into try-building-on-w…

852a8d2

…indows

add NEOFOAM_WITH_CUDA, default ON

0a4ebb7

check

40b4e2e

these changes are not needed if we build with nompi on Windows

91d6ce4

Revert "change to avoid compile error message: On Windows, the enclos…

fa82315

…ing parent function ('CATCH2_INTERNAL_TEST_0') for an extended __host__ __device__ lambda cannot have internal or no linkage" This reverts commit cf84406.

greole reviewed Oct 9, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

greole reviewed Oct 9, 2024

View reviewed changes

src/CMakeLists.txt Outdated Show resolved Hide resolved

Fitanium added 2 commits October 10, 2024 19:36

set NEOFOAM_ENABLE_CUDA to OFF for default config, and it's value wil…

cd8f8df

…l depend the configuration of Kokkos if found

comment out static lib

329956b

greole reviewed Oct 10, 2024

View reviewed changes

cmake/AutoEnableDevice.cmake Outdated Show resolved Hide resolved

Fitanium added 4 commits October 10, 2024 22:22

update logic to enable NEOFOAM_ENABLE_CUDA

f7d5790

minor improvements

57e6cb5

export symbols on windows

83728f9

format

3e74c06

greole requested a review from HenningScheufler October 11, 2024 14:48

Fitanium added 11 commits October 12, 2024 00:08

check

07111cb

copy dll on windows

e3535ba

improve logic

4dbe7e8

copy dll after build target neofoam_catch_main

54fdf2b

avoid warning C4530

bcbf6de

fix output directory of NeoFOAM

d632236

update add_custom_command

a6fa20a

check

e5101f2

also improve test output directory

ead59f7

check catch2/CMakeLists.txt

f0ac26d

fix an error in test/field.cpp

9349d1d

Fitanium force-pushed the try-building-on-windows branch from 76e4db3 to 9349d1d Compare October 13, 2024 08:45

update AUTHORS.md

8ae83a7

greole merged commit 9fc0360 into exasim-project:ci/win Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try building on windows #154

Try building on windows #154

Fitanium commented Oct 4, 2024

Fitanium commented Oct 6, 2024

greole commented Oct 6, 2024

greole left a comment

Try building on windows #154

Try building on windows #154

Conversation

Fitanium commented Oct 4, 2024

Fitanium commented Oct 6, 2024

greole commented Oct 6, 2024

greole left a comment

Choose a reason for hiding this comment