Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Impove test coverage of x/evm/statedb package #888

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jan 6, 2022

Description

Closes: #876

  • coverage: 99.3% of statements

The only two lines of code that is not covered are unreachable practically I believe:


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #888 (3de7452) into main (4320f46) will increase coverage by 3.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   56.86%   60.04%   +3.18%     
==========================================
  Files          77       77              
  Lines        6215     6195      -20     
==========================================
+ Hits         3534     3720     +186     
+ Misses       2487     2293     -194     
+ Partials      194      182      -12     
Impacted Files Coverage Δ
x/evm/statedb/access_list.go 96.42% <ø> (+90.63%) ⬆️
x/evm/statedb/state_object.go 100.00% <ø> (+21.48%) ⬆️
x/evm/statedb/statedb.go 99.20% <ø> (+32.41%) ⬆️
x/evm/statedb/journal.go 100.00% <0.00%> (+28.88%) ⬆️
x/evm/statedb/config.go 100.00% <0.00%> (+50.00%) ⬆️

@fedekunze fedekunze enabled auto-merge (squash) January 6, 2022 13:28
@yihuang
Copy link
Contributor Author

yihuang commented Jan 6, 2022

#536 (comment)

it seems the non-deterministic issue still exists, we should reopen that issue.

Closes: evmos#876
- coverage: 99.3% of statements
auto-merge was automatically disabled January 6, 2022 13:53

Head branch was pushed to by a user without write access

@fedekunze fedekunze merged commit e6c9b77 into evmos:main Jan 6, 2022
@yihuang yihuang deleted the statedb-test branch January 7, 2022 01:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impove test coverage of x/evm/statedb package
2 participants