This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
add exception revert test case #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure how to get it picked up in CI. |
| }) | ||
| it('should revert', async () => { | ||
| await revert.try_set(10) | ||
| no = await revert.query() |
There was a problem hiding this comment.
This will just throw and end the execution. You should use the expectRevert function which is defined above
There was a problem hiding this comment.
the test case actually success on ganache, only fail on ethermint.
There was a problem hiding this comment.
await revert.set(10) this can success on ganache?
There was a problem hiding this comment.
okay I saw the code. Yeah it should be success.
Once the #278 is merged this will be automatically executed. |
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 52.42% 52.59% +0.17%
==========================================
Files 46 46
Lines 4614 4620 +6
==========================================
+ Hits 2419 2430 +11
+ Misses 2093 2090 -3
+ Partials 102 100 -2
|
|
will open another PR to fix this issue directly, closing this one. |
yihuang
referenced
this pull request
in yihuang/ethermint
Sep 13, 2023
* Problem: block number is not filled in eth logs Solution: - fill in both block hash and block number in json-rpc - remove the block hash in events, to save some space in tx_indexer * fix unit test * fix unit test * fill in tx hash to logs * fix block number * cleanup * remove tx log event
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#338
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)