Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

return abci state's latest block number in rpc #331

Merged
merged 4 commits into from
Jul 22, 2021
Merged

return abci state's latest block number in rpc #331

merged 4 commits into from
Jul 22, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jul 21, 2021 •
edited
Loading

Closes #318

Description

abci app state could lag behind tendermint reported latest block number.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze
fedekunze approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. 2 suggestions

ethereum/rpc/backend/backend.go Outdated Show resolved Hide resolved
ethereum/rpc/backend/backend.go Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit 3f136bf into evmos:main Jul 22, 2021
mmsqe added a commit to mmsqe/ethermint that referenced this pull request Sep 6, 2023
@mmsqe @yihuang
Problem: abci handshake is not shutdown gracefully (#288) (evmos#331)
05e6989 
* Problem: abci handshake is not shutdown gracefully

Solution:
- use cancellable node constructor

* Update CHANGELOG.md



* fix grpc-only

* better app close

* log error

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query could fail with block number returned by eth_blockNumber api
2 participants
@yihuang @fedekunze