Geth upgrade v1.10.19 #1159

crypto-facs · 2022-06-29T00:35:31Z

Closes: #XXX

Description

The following changes were identified:

In RPC APIs where a block number can be given, you can now use "finalized" to refer to the latest finalized block. (#24282) → Update JSON-RPC
The EVM now implements EIP-3855 (PUSH0 instruction). This feature is not yet active in any fork. (#24039) → Update EnableEIPs
API change: debug_traceTransaction, in the default structured-logging mode, now returns the refund counter for every EVM execution step. (#24567)
eth/tracers: refactor traceTx to separate out struct logging 24326
MergeForkBlock renamed to MergeNetsplitBlock (#24904)

This last ones did not required any code changes as this endpoints are not yet supported on Ethermint:

some changes to debug_traceCall #24871

More info here
Will reject against pending blocks
Ability to override all evm-visible header fields.

> debug.traceCall({from: eth.accounts[0], value:"0x1", gasPrice: "0xffffffff", gas: "0xffff", input: "0x43"}, "latest", {"blockoverrides":{"number": "0x50"}})

The new debug_getRawReceipts RPC method returns the binary representation of block receipts. (#24773)
The new debug_dbGet method can be used to read from the chain database. (#24739)

NOTE

Since EIPs were modified, this changed required a migration to Ethermint v3.

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

proto/ethermint/evm/v1/evm.proto

x/evm/keeper/grpc_query.go

x/evm/migrations/v3/migrate.go

x/evm/migrations/v3/types/chain_config.go

x/evm/migrations/v3/migrate_test.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>

fedekunze

LGTM. Minor change requested on the proto msgs. Any other rpc endpoints that were introduced?

proto/ethermint/evm/v1/evm.proto

codecov · 2022-06-29T21:50:39Z

Codecov Report

Merging #1159 (4b04f17) into main (31c3660) will decrease coverage by 0.21%.
The diff coverage is 66.21%.

@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
- Coverage   61.76%   61.54%   -0.22%     
==========================================
  Files          90       91       +1     
  Lines        7312     7281      -31     
==========================================
- Hits         4516     4481      -35     
- Misses       2573     2577       +4     
  Partials      223      223

Impacted Files	Coverage Δ
x/evm/keeper/migrations.go	`50.00% <0.00%> (-16.67%)`	⬇️
x/evm/types/tracer.go	`7.14% <0.00%> (-48.60%)`	⬇️
x/evm/module.go	`52.05% <50.00%> (-0.81%)`	⬇️
x/evm/types/chain_config.go	`93.28% <54.54%> (-2.03%)`	⬇️
x/evm/migrations/v3/migrate.go	`73.33% <73.33%> (ø)`
x/evm/keeper/grpc_query.go	`68.91% <75.67%> (-0.34%)`	⬇️
rpc/types/block.go	`50.46% <100.00%> (ø)`
x/evm/keeper/state_transition.go	`74.77% <100.00%> (ø)`

x/evm/migrations/v2/types/chain_config.go

danburck

Looks good to me. Left a comment about the duplicated types in the migrations.

rpc/types/block.go

x/evm/migrations/v3/types/params.go

* upgrade geth and fix build * add support for * update EIPs * fix keeper tests * update traceTx function with latest geth changes * remove unnecessary comments * fix tests * update proto * add migrations * update module version * fix grpc test * fix lint * fix lint * update changelog * fix typo * remove unnecessary format logs * Update proto/ethermint/evm/v1/evm.proto Co-authored-by: Federico Kunze Küllmer <[email protected]> * remove debug true on default * update comments * fixing ante tests * fixed cycle imports on migrate_test * fix wrong naming * update comment Co-authored-by: Federico Kunze Küllmer <[email protected]>

giskook · 2022-10-03T23:51:41Z

x/evm/keeper/migrations.go

@@ -21,3 +22,8 @@ func NewMigrator(keeper Keeper) Migrator {
 func (m Migrator) Migrate1to2(ctx sdk.Context) error {
 	return v2.MigrateStore(ctx, &m.keeper.paramSpace)
 }
+
+// Migrate2to3 migrates the store from consensus version v2 to v3


// Migrate2to3 migrates the store from consensus version v2 to v3
Is the comment misleading? why it says consensus version?

Module's version for state migration for consensus state machine.

* upgrade geth and fix build * add support for * update EIPs * fix keeper tests * update traceTx function with latest geth changes * remove unnecessary comments * fix tests * update proto * add migrations * update module version * fix grpc test * fix lint * fix lint * update changelog * fix typo * remove unnecessary format logs * Update proto/ethermint/evm/v1/evm.proto Co-authored-by: Federico Kunze Küllmer <[email protected]> * remove debug true on default * update comments * fixing ante tests * fixed cycle imports on migrate_test * fix wrong naming * update comment Co-authored-by: Federico Kunze Küllmer <[email protected]>

crypto-facs added 11 commits June 26, 2022 08:58

upgrade geth and fix build

ce89ebe

add support for

6fe2876

update EIPs

28529f9

fix keeper tests

2dc6a48

update traceTx function with latest geth changes

ae80190

remove unnecessary comments

f3a5853

fix tests

7ec3963

merge main

036fd1f

update proto

a70558e

add migrations

8bcdf99

update module version

b34d1b2

crypto-facs requested review from fedekunze, khoslaventures and jolube as code owners June 29, 2022 00:35

crypto-facs added 5 commits June 28, 2022 20:50

fix grpc test

f806351

fix lint

83e0926

fix lint

9004071

update changelog

9c8e57c

fix typo

f292fa1

fedekunze reviewed Jun 29, 2022

View reviewed changes

crypto-facs and others added 6 commits June 29, 2022 10:15

remove unnecessary format logs

6a0b8a3

Update proto/ethermint/evm/v1/evm.proto

acdbe39

Co-authored-by: Federico Kunze Küllmer <[email protected]>

remove debug true on default

c8574a7

update comments

4e5c04c

fixing ante tests

1863034

fixed cycle imports on migrate_test

782922a

fedekunze requested a review from danburck June 29, 2022 17:19

fedekunze approved these changes Jun 29, 2022

View reviewed changes

proto/ethermint/evm/v1/evm.proto Outdated Show resolved Hide resolved

proto/ethermint/evm/v1/evm.proto Outdated Show resolved Hide resolved

fix wrong naming

96a64b4

yihuang reviewed Jun 30, 2022

View reviewed changes

x/evm/migrations/v2/types/chain_config.go Show resolved Hide resolved

danburck reviewed Jul 5, 2022

View reviewed changes

rpc/types/block.go Show resolved Hide resolved

x/evm/migrations/v3/types/params.go Show resolved Hide resolved

crypto-facs and others added 2 commits July 6, 2022 09:38

update comment

65c320c

Merge branch 'main' into geth-upgrade-19

4b04f17

fedekunze approved these changes Jul 8, 2022

View reviewed changes

fedekunze enabled auto-merge (squash) July 8, 2022 10:52

fedekunze merged commit 4a6f4fd into evmos:main Jul 8, 2022

yihuang mentioned this pull request Jul 14, 2022

Problem: traceTransaction always returns success for simple transfer tx #1185

Closed

yihuang added a commit to yihuang/ethermint that referenced this pull request Jul 26, 2022

imp(deps): Geth upgrade v1.10.19 (backport evmos#1159)

f646d1f

giskook reviewed Oct 3, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Geth upgrade v1.10.19 #1159

Geth upgrade v1.10.19 #1159

crypto-facs commented Jun 29, 2022

fedekunze left a comment

codecov bot commented Jun 29, 2022 •

edited

Loading

danburck left a comment

giskook Oct 3, 2022

yihuang Oct 4, 2022

Geth upgrade v1.10.19 #1159

Geth upgrade v1.10.19 #1159

Conversation

crypto-facs commented Jun 29, 2022

Description

NOTE

fedekunze left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 29, 2022 • edited Loading

Codecov Report

danburck left a comment

Choose a reason for hiding this comment

giskook Oct 3, 2022

Choose a reason for hiding this comment

yihuang Oct 4, 2022

Choose a reason for hiding this comment

codecov bot commented Jun 29, 2022 •

edited

Loading