This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
commented
Apr 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #1059 +/- ##
==========================================
+ Coverage 60.77% 60.79% +0.02%
==========================================
Files 80 80
Lines 6666 6670 +4
==========================================
+ Hits 4051 4055 +4
Misses 2404 2404
Partials 211 211
|
ENG-193 Base fee is not dynamic
The base fee is not updated correctly and remains static at the value set in Example:
|
Could you add to the description what the issue is and how it's being addressed? |
@jolube added a short description. I'll add more details as soon as we add more tests to check the behavior |
…edekunze/debug-basefee
crypto-facs
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yihuang
pushed a commit
to yihuang/ethermint
that referenced
this pull request
Apr 29, 2022
* release: v0.14.0 changelog (evmos#1057) * fix: update BaseFee JSON-RPC * typo * changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the event filtering logic on the current BaseFee JSON-RPC endpoint.
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)