Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: update BaseFee JSON-RPC #1059

Merged
merged 8 commits into from
Apr 26, 2022
Merged

fix: update BaseFee JSON-RPC #1059

merged 8 commits into from
Apr 26, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Apr 21, 2022

Description

This PR removes the event filtering logic on the current BaseFee JSON-RPC endpoint.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #1059 (42cc265) into main (825d393) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 42cc265 differs from pull request most recent head 77c3e61. Consider uploading reports for the commit 77c3e61 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
+ Coverage   60.77%   60.79%   +0.02%     
==========================================
  Files          80       80              
  Lines        6666     6670       +4     
==========================================
+ Hits         4051     4055       +4     
  Misses       2404     2404              
  Partials      211      211              
Impacted Files Coverage Δ
x/feemarket/keeper/eip1559.go 89.83% <100.00%> (+0.73%) ⬆️

@linear
Copy link

linear bot commented Apr 21, 2022

ENG-193 Base fee is not dynamic

The base fee is not updated correctly and remains static at the value set in x/feemarket.

Example:

❯ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_gasPrice","params":[],"id":73}' -H "Content-Type: application/json" https://eth.bd.evmos.dev:8545

{
  "jsonrpc": "2.0",
  "id": 73,
  "result": "0x7"
}

x/feemarket params pulled from evmos_9000-4:

❯ evmosd query feemarket params --chain-id=evmos_9000-4 --node=https://tendermint.bd.evmos.dev:26657/ --output=json

{
  "params": {
    "no_base_fee": false,
    "base_fee_change_denominator": 8,
    "elasticity_multiplier": 2,
    "enable_height": "0",
    "base_fee": "7"
  }
}

@jolube
Copy link
Contributor

jolube commented Apr 21, 2022

Could you add to the description what the issue is and how it's being addressed?

@fedekunze
Copy link
Contributor Author

@jolube added a short description. I'll add more details as soon as we add more tests to check the behavior

@fedekunze fedekunze marked this pull request as ready for review April 26, 2022 10:13
Copy link
Contributor

@crypto-facs crypto-facs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze enabled auto-merge (squash) April 26, 2022 11:03
@fedekunze fedekunze merged commit 0f09964 into main Apr 26, 2022
@fedekunze fedekunze deleted the fedekunze/debug-basefee branch April 26, 2022 14:24
yihuang pushed a commit to yihuang/ethermint that referenced this pull request Apr 29, 2022
* release: v0.14.0 changelog (evmos#1057)

* fix: update BaseFee JSON-RPC

* typo

* changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants