Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

tests: Add more dynamic fee tx tests #1032

Merged
merged 2 commits into from
Apr 6, 2022
Merged

tests: Add more dynamic fee tx tests #1032

merged 2 commits into from
Apr 6, 2022

Conversation

MalteHerrmann
Copy link
Contributor

Addresses: #1017

Description

Hi, I want to start contributing to the repo and figured writing tests is a good way to start.
Please point me towards any improvements I can make for future PRs and changes that are necessary for this PR to be accepted.

I have added a test for the AsEthereumData method of DynamicFeeTx and some edge case tests regarding overflowing big.Ints.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks!

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1032 (fc9430b) into main (ea3c16e) will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
+ Coverage   59.32%   59.70%   +0.38%     
==========================================
  Files          80       80              
  Lines        6576     6576              
==========================================
+ Hits         3901     3926      +25     
+ Misses       2456     2434      -22     
+ Partials      219      216       -3     
Impacted Files Coverage Δ
x/evm/types/dynamic_fee_tx.go 89.94% <0.00%> (+13.96%) ⬆️

@fedekunze fedekunze merged commit c70701e into evmos:main Apr 6, 2022
@MalteHerrmann MalteHerrmann deleted the add-dynamic-fee-tx-tests branch April 6, 2022 19:47
@fedekunze
Copy link
Contributor

@MalteHerrmann you can prob open a similar PR for x/evm/msg.go or x/evm/access_list_tx.go

@MalteHerrmann
Copy link
Contributor Author

@fedekunze Will do!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants