Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

make build failed with incompatible CodeHash type #99

Closed
calvinaco opened this issue Jun 9, 2021 · 1 comment · Fixed by #100
Closed

make build failed with incompatible CodeHash type #99

calvinaco opened this issue Jun 9, 2021 · 1 comment · Fixed by #100

Comments

@calvinaco
Copy link
Contributor

After the changes in #84, CodeHash becomes a string type and will break the line https://github.com/calvinaco/ethermint/blob/main/ethereum/rpc/eth_api.go#L954 with the following error on build:

ethereum/rpc/eth_api.go:954:39: cannot use res.CodeHash (type string) as type []byte in argument to common.BytesToHash
make: *** [build] Error 2
@calvinaco
Copy link
Contributor Author

I am taking this task

@khoslaventures khoslaventures added this to the Milestone 1: Developer Usability and Testing milestone Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants