Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

eth_sendTransaction returns internal trace on missing param #1275

Closed
facs95 opened this issue Aug 16, 2022 · 0 comments · Fixed by #1284
Closed

eth_sendTransaction returns internal trace on missing param #1275

facs95 opened this issue Aug 16, 2022 · 0 comments · Fixed by #1284
Assignees
Labels

Comments

@facs95
Copy link
Contributor

facs95 commented Aug 16, 2022

System info: [Include Ethermint commit, operating system name, and other relevant details]

Steps to reproduce:

  1. Query eth_sendTransaction without the from parameter in the request

Expected behavior: [What you expected to happen] Nicely formatted error

Actual behavior: [What actually happened] You will get the following response

ValueError: {'code': -32000, 'message': 'rpc error: code = Unknown desc = \ngithub.com/cosmos/cosmos-sdk/baseapp.gRPCErrorToSDKError\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/cosmos/cosmos-sdk/baseapp/abci.go:603\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).handleQueryGRPC\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/cosmos/cosmos-sdk/baseapp/abci.go:579\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).Query\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/cosmos/cosmos-sdk/baseapp/abci.go:421\ngithub.com/tendermint/tendermint/abci/client.(*localClient).QuerySync\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:256\ngithub.com/tendermint/tendermint/proxy.(*appConnQuery).QuerySync\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:159\ngithub.com/tendermint/tendermint/rpc/core.ABCIQuery\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/tendermint/tendermint/rpc/core/abci.go:20\ngithub.com/tendermint/tendermint/rpc/client/local.(*Local).ABCIQueryWithOptions\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/tendermint/tendermint/rpc/client/local/local.go:87\ngithub.com/cosmos/cosmos-sdk/client.Context.queryABCI\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/cosmos/cosmos-sdk/client/query.go:94\ngithub.com/cosmos/cosmos-sdk/client.Context.QueryABCI\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/cosmos/cosmos-sdk/client/query.go:57\ngithub.com/cosmos/cosmos-sdk/client.Context.Invoke\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/cosmos/cosmos-sdk/client/grpc_query.go:81\ngithub.com/evmos/ethermint/x/evm/types.(*queryClient).EstimateGas\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/x/evm/types/query.pb.go:1473\ngithub.com/evmos/ethermint/rpc/backend.(*Backend).EstimateGas\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/rpc/backend/call_tx.go:310\ngithub.com/evmos/ethermint/rpc/namespaces/ethereum/eth.(*PublicAPI).EstimateGas\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/rpc/namespaces/ethereum/eth/api.go:345\nreflect.Value.call\n\t/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.18.3/share/go/src/reflect/value.go:556\nreflect.Value.Call\n\t/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.18.3/share/go/src/reflect/value.go:339\ngithub.com/ethereum/go-ethereum/rpc.(*callback).call\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/ethereum/go-ethereum/rpc/service.go:206\ngithub.com/ethereum/go-ethereum/rpc.(*handler).runMethod\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/ethereum/go-ethereum/rpc/handler.go:389\ngithub.com/ethereum/go-ethereum/rpc.(*handler).handleCall\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/ethereum/go-ethereum/rpc/handler.go:337\ngithub.com/ethereum/go-ethereum/rpc.(*handler).handleCallMsg\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/ethereum/go-ethereum/rpc/handler.go:298\ngithub.com/ethereum/go-ethereum/rpc.(*handler).handleMsg.func1\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/ethereum/go-ethereum/rpc/handler.go:139\ngithub.com/ethereum/go-ethereum/rpc.(*handler).startCallProc.func1\n\t/private/tmp/nix-build-ethermintd-v0.17.1.drv-0/source/vendor/github.com/ethereum/go-ethereum/rpc/handler.go:226\nrpc error: code = Internal desc = insufficient balance for transfer: unknown request'}

Additional info: [Include gist of relevant config, logs, etc.]

@facs95 facs95 added the C:JSON-RPC JSON-RPC client label Aug 16, 2022
@danburck danburck moved this to 🧐 Triaged in Ethermint Board Aug 17, 2022
@danburck danburck moved this from 🧐 Triaged to 🔖 Todo in Ethermint Board Aug 17, 2022
@adisaran64 adisaran64 moved this from 🔖 Todo to 🏗 In progress in Ethermint Board Aug 19, 2022
@facs95 facs95 moved this from 🏗 In progress to 👀 In review in Ethermint Board Aug 22, 2022
@facs95 facs95 moved this from 👀 In review to ✅ Done in Ethermint Board Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants