update comments

evmos · Jun 13, 2022 · 40888a0 · 40888a0
1 parent 4e5a350
commit 40888a0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/docs/api/proto-docs.md b/docs/api/proto-docs.md
@@ -444,6 +444,7 @@ DynamicFeeTx is the data of EIP-1559 dinamic fee transactions.
 
 ### LegacyTx
 LegacyTx is the transaction data of regular Ethereum transactions.
+NOTE: All non-protected transactions (i.e non EIP155 signed) will fail if the RejectUnprotectedTx parameter is enabled.
 
 
 | Field | Type | Label | Description |

diff --git a/proto/ethermint/evm/v1/tx.proto b/proto/ethermint/evm/v1/tx.proto
@@ -36,6 +36,7 @@ message MsgEthereumTx {
 }
 
 // LegacyTx is the transaction data of regular Ethereum transactions.
+// NOTE: All non-protected transactions (i.e non EIP155 signed) will fail if the RejectUnprotectedTx parameter is enabled. 
 message LegacyTx {
   option (gogoproto.goproto_getters) = false;
   option (cosmos_proto.implements_interface) = "TxData";

diff --git a/x/evm/types/tx.pb.go b/x/evm/types/tx.pb.go
diff --git a/x/evm/types/tx_data.go b/x/evm/types/tx_data.go
@@ -46,6 +46,7 @@ type TxData interface {
 	EffectiveCost(baseFee *big.Int) *big.Int
 }
 
+// NOTE: All non-protected transactions (i.e non EIP155 signed) will fail if the RejectUnprotectedTx parameter is enabled.
 func NewTxDataFromTx(tx *ethtypes.Transaction) (TxData, error) {
 	var txData TxData
 	var err error