-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placeholders or skeletons to components #1300
Comments
I don't think this is a bug, we just don't have skeleton states in most (all) of the components, given how fast they are already. @ItsMeBrianD has done some work on this on next. |
I think that's because we default to not showing |
That's right -- you could set it to be included by default during SSR but then it would jank off the page for most folks who have queries hidden. |
Queryviewer is a bit of a special case, but SSR'ing the charts would definitely be a good improvement |
ECharts SSR'd charts are currently more of an embedded thing (i.e. something you would return from an endpoint and you link to it as a |
Steps To Reproduce
Expected Behavior
There is some static image or placeholder of a chart visible when the page is loading
Actual Behaviour
Some components are not visible while the page loads.
This includes the Charts and the Query Viewer, but not the DataTable, Value or BigValue
The text was updated successfully, but these errors were encountered: