Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easee: fix PhaseGetter returning used, not configured, phases #17326

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Easee: fix PhaseGetter returning used, not configured, phases #17326

merged 6 commits into from
Nov 19, 2024

Conversation

GrimmiMeloni
Copy link
Collaborator

fix #17280

marking as draft until I can test it locally later today

@GrimmiMeloni GrimmiMeloni self-assigned this Nov 18, 2024
@GrimmiMeloni GrimmiMeloni added bug Something isn't working devices Specific device support labels Nov 18, 2024
@GrimmiMeloni GrimmiMeloni mentioned this pull request Nov 18, 2024
Closed
1 task
andig
andig reviewed Nov 18, 2024
View reviewed changes
charger/easee.go Outdated Show resolved Hide resolved
@GrimmiMeloni GrimmiMeloni marked this pull request as ready for review November 18, 2024 21:49
@GrimmiMeloni
Copy link
Collaborator Author

Tested with my circuit controlled charger. Looking good so far.
I do not have a 1p cable to test the situation of the actual bug report (charger in 3p, car only taking 1p) though. But at least 1p / 3p continues to work as expected, and charger does not go out of sync on phases. So I think this is solid.

@andig andig merged commit c44c598 into evcc-io:master Nov 19, 2024
6 checks passed
mabunixda added a commit to mabunixda/evcc that referenced this pull request Nov 22, 2024
@mabunixda
Merge branch 'master' into local/patched
cbdecb6 
* master: (58 commits)
  Add Huawei EMMA (evcc-io#17338)
  Config UI: device value formatting (evcc-io#17258)
  chore: upgrade npm dependencies (evcc-io#17344)
  chore: fix template
  Easee: fix PhaseGetter returning used, not configured, phases  (evcc-io#17326)
  chore: refactor
  MacOS: add gobuildid
  Script: simplify setters
  Tariffs: formula, charges, tax > advanced fields (evcc-io#17301)
  Push: add custom messenger (BC) (evcc-io#17211)
  Script: add missing string setter (evcc-io#17314)
  Sofar: fix docs (evcc-io#17324)
  Polestar: skip test
  Polestar: fix authentication (evcc-io#17276)
  chore: fix line breaks
  chore: fix quotes
  Add Tessie (evcc-io#17274)
  PUN: update api endpoint (evcc-io#17270)
  Revert "EM24: add pv usage & fix energy (evcc-io#17173)"
  Enphase: fix soc
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig andig left review comments

Assignees

@GrimmiMeloni GrimmiMeloni

Labels
bug Something isn't working devices Specific device support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

easee: evcc constantly switches between pause and resume
2 participants
@GrimmiMeloni @andig