Polestar: Change authentication flow to deny cookies #17276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rostbeule / @scyomantion / @andig As mentioned above, I was able to make it run with the following code. Please let me know what you think! |
|
Nice, I had the same thought earlier. You're capturing both values before and avoid passing param into the function directly. That would have caused issues in my case. I like this approach. In my view, my PR is obsolete then. I did mention somewhere that I wouldn't have time for it until Sunday. The sun isn't shining anyway =D |
|
I've lost track. Does this now work as-is? |
andig
requested changes
Nov 16, 2024
This was referenced Nov 16, 2024
Co-authored-by: andig <[email protected]>
Co-authored-by: andig <[email protected]>
Co-authored-by: andig <[email protected]>
Co-authored-by: andig <[email protected]>
Co-authored-by: andig <[email protected]>
|
Thanks for your comments @andig |
|
Great, thank you! |
mabunixda
added a commit
to mabunixda/evcc
that referenced
this pull request
Nov 22, 2024
* master: (58 commits) Add Huawei EMMA (evcc-io#17338) Config UI: device value formatting (evcc-io#17258) chore: upgrade npm dependencies (evcc-io#17344) chore: fix template Easee: fix PhaseGetter returning used, not configured, phases (evcc-io#17326) chore: refactor MacOS: add gobuildid Script: simplify setters Tariffs: formula, charges, tax > advanced fields (evcc-io#17301) Push: add custom messenger (BC) (evcc-io#17211) Script: add missing string setter (evcc-io#17314) Sofar: fix docs (evcc-io#17324) Polestar: skip test Polestar: fix authentication (evcc-io#17276) chore: fix line breaks chore: fix quotes Add Tessie (evcc-io#17274) PUN: update api endpoint (evcc-io#17270) Revert "EM24: add pv usage & fix energy (evcc-io#17173)" Enphase: fix soc ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17186
I took the liberty to create a PR to implement the changes discussed in #17186 and #17252 to speed up the process 😉
Main change is to check for the
uidand then deny the cookies usingconfirmConsentAndGetCodeI was able to successfully test this with my Polestar 2