Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: additional renaming control #6

Open
psulat opened this issue Feb 27, 2016 · 2 comments
Open

Feature Request: additional renaming control #6

psulat opened this issue Feb 27, 2016 · 2 comments

Comments

@psulat
Copy link

psulat commented Feb 27, 2016

Evan,

I was thinking it would be nice to have the ability to selectively turn renaming off/on for varying vars and uniforms. This is needed to better support the ability to share a common vertex shader with multiple fragment shaders, or vice-versa. Currently, you can do this either by turning off renaming of all uniforms, attribute and varying or you can include multiple shaders in one file. I think there is a third option where you turn off renaming of varying (they tightly couple vertex and uniforms), always rename attributes (no coupling) and only rename uniforms in the fragment or vertex shader that you really want to protect. (normally you only need to protect one or the other). This third option could easily be accomplished if we had an option to selectively control renaming of varying and uniforms. At a minimum only control of varying is needed.

Pete

@seanpkent
Copy link

@psulat If you are still interested, I created a fork with a small change that prevents renaming of varyings when internal-only renaming parameter is enabled.
https://github.com/seanpkent/glslx

@psulat
Copy link
Author

psulat commented May 7, 2018

@seanpkent Cool! Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants