fix deprecated Deno APIs "Deno.stderr.rid" "Deno.isatty()" "Deno.run()" #3610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deno v1.40.0 was released deprecating:
Deno.isatty()
Deno.stderr.rid
Deno.run
was previously deprecated to be replaced withDeno.Command
.This PR does the minimum to replace the deprecated APIs and fixes #3609
I had to modify
deno-tests.js
to callesbuildNative.initialize()
andesbuildNative.stop()
only once before and after the tests. Deno test was complaing about "Leaking async ops" and failing the first test despite the asserts being true.I think the child process read/write code could be smaller now (e.g. without the need for
startWriteFromQueueWorker
) but I haven't done any extra refactoring here.