Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assoc handles and attentions with adequate parent link #33

Merged

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Jun 19, 2014

(*-objects.l)
Assoc handles and attentions with adequate parent link.
This bug is reported in #31

snozawa added a commit that referenced this pull request Jun 19, 2014
@snozawa snozawa merged commit 19a93dc into euslisp:master Jun 19, 2014
@k-okada
Copy link
Member

k-okada commented Jun 20, 2014

how did you create this models. #27 (comment) said it hard to generate models at this moment. Did you fixed #34 ?

@snozawa
Copy link
Contributor Author

snozawa commented Jun 20, 2014

Temporarily I created this model by adding diff in rbrain/Makefile.generic.

copy-converted-irtmodels-to-euslisp-models-repository:
        -echo "(progn (defun remove-duplicates (seq &key (test #'eq) (test-not) (key #'identity)\
                                   (start 0) (end 1000000))\
   (system::raw-remove-duplicates seq test test-not key start end)) (copy-converted-irtmodels-to-euslisp-models-repository) (exit))" | $(BINDIR)/jskrbeusgl convert-model-test.l

Before reverting remove-duplicates, I was waiting for downstream package upgrade from previous Euslisp DEB-release.
jsk-ros-pkg/jsk_pr2eus#35
At this time, I'd like to fix this PR before new euslisp DEB releasing, but it takes so long time...

Is it better to revert remove-duplicate first?
#34

@snozawa snozawa deleted the assoc_handle_attention_to_adequate_links branch September 28, 2014 17:01
snozawa added a commit that referenced this pull request Feb 9, 2015
mmurooka pushed a commit to mmurooka/EusLisp that referenced this pull request Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants