Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable key functions; plus ignore them when editable element is focused #42

Open
pintassilgo opened this issue Mar 9, 2021 · 0 comments

Comments

@pintassilgo
Copy link

pintassilgo commented Mar 9, 2021

Hi. Three suggestions related to key functions:

  1. Option to disable individual key functions.
  2. Remove some useless key functions, as they are default in any video (HTML5): spacebar to play/pause, home/end to start/end, arrow keys...
  3. Ignore key functions entirely if focused element (event.target) is editable (tagName == 'INPUT' || tagName == 'TEXTAREA' || tagName.isContentEditable || tagName == 'SELECT').

In case you don't understand how 3 could be valid if video is maximized: I use a sticky note addon for many reasons, one of them is to track where I stopped in long videos, so that I know where to start when I get back. Obviously, the content of this type of note consist of just numbers, but if I press, let's say, '5', instead of the number being typed in the note I end up with the video skipping to the middle of the duration.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant