Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staggered Grid only displaying first two items from the adapter in above 17+ device. #13

Closed
Kenmraju opened this issue Dec 28, 2013 · 8 comments
Labels

Comments

@Kenmraju
Copy link

The grid items were stretching earlier which was solved by using the dynamic image height but, then the grid stopped populating views after first two items.

@denizmveli
Copy link
Contributor

Can you please provide a code sample or a link to your fork? I can't really help you with the info you've provided.

@sherzberg
Copy link

I ran into this as well. If you have com.android.tools.build upgraded, compileSdkVersion, targetSdkVersion it looks like the first item in each column is infinitely long. I also double checked by doing this to your Sample Project:

buildscript {
    repositories {
        mavenCentral()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:0.7.1'
    }
}
apply plugin: 'android'

repositories {
    mavenCentral()
}

android {
    compileSdkVersion 18
    buildToolsVersion "19.0.0"

    defaultConfig {
        minSdkVersion 10
        targetSdkVersion 18
    }
}

dependencies {
    compile project(':library')
}

@emilsjolander
Copy link
Contributor

My pull request #16 fixes this issue

@denizmveli
Copy link
Contributor

Yep closing as duplicate of #16

@Kenmraju
Copy link
Author

Thank you @denizmveli @sherzberg @emilsjolander this has solved the problem.

@denizmveli
Copy link
Contributor

Cool. Can I ask why you guys need to change the target/compile version?

@emilsjolander
Copy link
Contributor

The app cannot compile with mutiple compile targets so it will choose the compile target that the main app uses. The app i am making targets kitkat.

@emilsjolander
Copy link
Contributor

To clarify, we do not need to change the target of the library but the library will still need to work with compile targets higher than 17 as the compile target is chosen based on when the main app specifies and not the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants