Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of columns that will be dropped in Prophet model #13

Closed
Mr-Geekman opened this issue Aug 14, 2023 · 1 comment
Closed

Add list of columns that will be dropped in Prophet model #13

Mr-Geekman opened this issue Aug 14, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers priority/medium Medium priority task

Comments

@Mr-Geekman
Copy link

Issue by iKintosh
Friday Jun 17, 2022 at 12:41 GMT
Originally opened as tinkoff-ai#757


🚀 Feature Request

We show dropped columns during fitting SARIMAX, but don't show it for the Prophet.

Proposal

We should add the list of dropped columns during fitting of ProphetModel like we do for SARIMAXModel:

  warnings.warn(
      message=f"Prophet model does not work with exogenous features (features unknown in future).\n "
      f"{column_to_drop} will be dropped"
  )

Additional context

No response

@Mr-Geekman Mr-Geekman added enhancement New feature or request good first issue Good for newcomers priority/medium Medium priority task labels Aug 14, 2023
@Mr-Geekman Mr-Geekman moved this to Todo in etna board Aug 15, 2023
@d-a-bunin
Copy link
Collaborator

Closed by tinkoff-ai#1312.

@github-project-automation github-project-automation bot moved this from Todo to Done in etna board Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority/medium Medium priority task
Projects
Status: Done
Development

No branches or pull requests

2 participants