Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Theme Material UI Chips Leading Icon Size Wrong #66

Open
huayunh opened this issue Apr 5, 2023 · 0 comments
Open

Dark Theme Material UI Chips Leading Icon Size Wrong #66

huayunh opened this issue Apr 5, 2023 · 0 comments
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something isn't working

Comments

@huayunh
Copy link
Contributor

huayunh commented Apr 5, 2023

Describe the bug / expected behavior

Light theme and dark theme chips icon should be consistent. Right now the light theme icon is correctly sized at 18px, but the dark theme is not set, leaving it at 24px.

What are the steps to reproduce?

  1. Go to the showcase demo
  2. toggle light / dark themes while observing the chips resizing itself

Screenshots / Screen recording

Light (the correct size):
image
Dark:
image

Suggested fix

This blurb is only present in the light theme. It needs to be added to the dark theme as well.

icon: {
fontSize: "1.125rem",
color: ThemeColors.text.primary,
marginLeft: Spacing,
marginRight: -4,
},

@huayunh huayunh added bug Something isn't working needs-review Issues that we would like to revisit/review brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering labels Apr 5, 2023
@JeffGreiner-eaton JeffGreiner-eaton removed the needs-review Issues that we would like to revisit/review label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something isn't working
Development

No branches or pull requests

2 participants