Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning snackbar inaccessible #34

Open
huayunh opened this issue Mar 4, 2022 · 3 comments
Open

Warning snackbar inaccessible #34

huayunh opened this issue Mar 4, 2022 · 3 comments
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement New feature or request
Milestone

Comments

@huayunh
Copy link
Contributor

huayunh commented Mar 4, 2022

Describe the desired behavior

One should never have white text on yellow bg color.

dark text like black500 or the proposed theme.palette.warning.dark might be better

Describe the current behavior

image

Additional Context

In MUI v5 there's this color="warning" or color="success" introduced. This is going to be a big accessibility issue for a lot of components, not just snackbars. Buttons, for example, would start to look like this
image

@huayunh huayunh added enhancement New feature or request needs-review Issues that we would like to revisit/review labels Mar 4, 2022
@huayunh huayunh mentioned this issue Mar 4, 2022
6 tasks
@jeffvg jeffvg removed the needs-review Issues that we would like to revisit/review label Mar 16, 2022
@jeffvg
Copy link
Contributor

jeffvg commented Mar 16, 2022

TBD`Having a meeting on this and will discover the update from that

@emclaug2 emclaug2 added this to the 7.1.0 milestone Apr 15, 2022
@daileytj daileytj removed this from the 7.1.0 milestone Nov 7, 2022
@daileytj
Copy link
Contributor

daileytj commented Nov 7, 2022

Removing the milestone allocation until we get more information on acceptance criteria.

@huayunh can you look at this again and give some guidance as to whether we want to address this as a one off thing here or make it part of the larger accessibility updates coming in the future?

@huayunh
Copy link
Contributor Author

huayunh commented Nov 8, 2022

this is an a11y thing

@daileytj daileytj added this to the 7.2.0 milestone Nov 30, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement New feature or request
Development

No branches or pull requests

5 participants