Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom sheet items should be contained in the safe-area-view for the action list example #114

Open
daileytj opened this issue Apr 8, 2022 · 0 comments
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected

Comments

@daileytj
Copy link
Contributor

daileytj commented Apr 8, 2022

Describe the bug

The Overlay that appears from the bottom of the screen is bleeding into the Safe-Area-View.

What is the expected behavior?

This overlay (Bottom Sheet) should be contained in the safe-area-view.

What are the steps to reproduce?

  1. Clone this repo and cd into it.
  2. Consult the README for instructions for running on android or ios.
  3. Navigate to the Action List example via the Drawer.
  4. Open bottom sheet via 3-dot button.
  5. Observe bottom sheet list item outside the safe area.

Screenshots or links to minimum reproduction example

This is an old image from before the list item heights were fixed, but still gets the point across
image

Additional context: the bottom sheet example is doing this correctly so be sure to see how this is being handled there

This examples needs to be ran on a simulator that has a notch, iphone / Samsung 11.

@daileytj daileytj added bug Something not working as expected needs-review Issues that we would like to revisit/review labels Apr 8, 2022
@bkarambe bkarambe removed the needs-review Issues that we would like to revisit/review label Apr 27, 2022
@joebochill joebochill added hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 hacktoberfest Issues shared for contributions by the Hacktoberfest community labels Sep 26, 2022
@daileytj daileytj removed hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 hacktoberfest Issues shared for contributions by the Hacktoberfest community labels Nov 28, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected
Development

No branches or pull requests

3 participants