-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation tabs inside CollapsibleHeaderLayout are not supported #288
Comments
From Swati Jain: "I have tried by keeping tab navigator outside of the CollapsibleHeader component and with this we are able to render the tabs perfectly But header is not scrollable with this approach as it will not have much content to get scroll area. As per current UX design, it’s expected to scroll (expand/collapse) header and to achieve this all the bottom content we should keep it inside CollapsibleHeader. " |
See if we can put together a code snippet for this. |
Hi @daileytj Did you get a chance to look into this ? |
Hi @swati-eaton We are currently looking at this issue. We will update you soon. |
Hi @swati-eaton , However, the main issue you are seeing is caused by react-navigation/material-top-tabs which uses react-native-tab-view. This view does not work when it is placed inside of a Scrollview (like the body of the CollapsibleHeaderLayout) or some other containers — refer to react-navigation/react-navigation#10361. And when putting it in the Header, it tries to render both the tabs and the pages in the Header, which is not desirable. You'll probably need to tackle this from a more custom approach in order to separate the Tabs from the content (as you are trying to do in your design). You may be able to do this by treating the tabs as separate routes in a Stack Navigator, or manually implementing the paging with something like react-native-pager-view within the CollapsibleHeaderLayout body. |
We need to add Tab.Navigator inside CollapsibleHeaderLayout
Component : https://brightlayer-ui-components.github.io/react-native/?path=/info/components-documentation--collapsible-header-layout
When we try to do same, corresponding tabs screens are not getting rendered and swipe functionality is also not working.
The text was updated successfully, but these errors were encountered: