Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserMenu component should have better test coverage #106

Closed
daileytj opened this issue Feb 1, 2021 · 0 comments · Fixed by #327
Closed

UserMenu component should have better test coverage #106

daileytj opened this issue Feb 1, 2021 · 0 comments · Fixed by #327
Assignees
@surajeaton
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Milestone
7.1.0

Comments

@daileytj
Copy link
Contributor

daileytj commented Feb 1, 2021

Describe the desired behavior

The UserMenu component should have better test coverage including but not limited to:
"should not render bottom sheet before avatar press event"
"should render bottom sheet on avatar press"
"should render bottom sheet InfoListItem with correct content"

Describe the current behavior

The UserMenu only has one test for "should render avatar with correct label"
@daileytj daileytj added the enhancement Request for improvement or new feature label Feb 1, 2021
@joebochill joebochill added this to the 6.1.0 milestone Dec 27, 2021
@daileytj daileytj modified the milestone: 7.1.0 Nov 28, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
@surajeaton surajeaton self-assigned this Jan 13, 2023
@surajeaton surajeaton mentioned this issue Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surajeaton surajeaton

Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Updated test cases for user menu etn-ccis/blui-react-native-component-library
3 participants
@daileytj @joebochill @surajeaton