Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classes props from component #917

Open
joebochill opened this issue Oct 21, 2024 · 1 comment
Open

Remove classes props from component #917

joebochill opened this issue Oct 21, 2024 · 1 comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Milestone

Comments

@joebochill
Copy link
Collaborator

Describe the desired feature/functionality

Remove the classes props from components.

Additional Context (where / how would this be used)

With the sx styles, it's much easier to target nested elements for styling, so this is unnecessary and bloats the components.

Is this request related to a current issue?

Suggested implementation details

Replace the classes prop with a hardcoded class name on various structural elements, all prefixed with Blui<ComponentName>-. Refactor styles to use sx and nested sx rules where appropriate.

@joebochill joebochill added enhancement Request for improvement or new feature needs-review Issues that we would like to revisit/review brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering labels Oct 21, 2024
@joebochill joebochill added this to the 7.0.0 milestone Oct 21, 2024
@joebochill
Copy link
Collaborator Author

After looking at this, I don't think it'ss hurting anything to keep these classes in — it just give YET ANOTHER way to do style overriding (possibly adding confusion and inconsistency). So I don't think we really need to change this, but I just wanted to capture the idea in case we want to simplify things.

This would be a breaking change, so we could roll it in with the MUI 6 migration in v7 if we wanted to do it.

@manojleaton manojleaton removed the needs-review Issues that we would like to revisit/review label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Development

No branches or pull requests

2 participants