Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuListProps in UserMenu's Menu components are not overriding #893

Closed
surajeaton opened this issue Jul 12, 2024 · 0 comments
Closed

MenuListProps in UserMenu's Menu components are not overriding #893

surajeaton opened this issue Jul 12, 2024 · 0 comments
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected user-reported This was reported by a user outside the maintainers team.
Milestone
6.3.1

Comments

@surajeaton
Copy link
Contributor

Describe the bug / expected behavior

What are the steps to reproduce?

  1. yarn start
  2. Pass MenuProps={{MenuListProps: { dataTestId: 'user-menu-one'}}} to UserMenu component
  3. Go to Brightlayer UI Component's Data Display
  4. Scroll down to the User Menu
  5. Click on User Menu
  6. Inspect User Menu
  7. MenuListProps are not applying

Screenshots / Screen recording

Code snippet / Link to minimum reproduction example

MenuProps={{MenuListProps: { dataTestId: 'user-menu-one'}}}

Your environment information

Suggested fix

Spread MenuListProps from MenuProps and merge with the default MenuListProps

Anything else to add?
@surajeaton surajeaton added bug Something not working as expected needs-review Issues that we would like to revisit/review user-reported This was reported by a user outside the maintainers team. brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering labels Jul 12, 2024
@ektaghag-eaton ektaghag-eaton removed the needs-review Issues that we would like to revisit/review label Jul 31, 2024
@ektaghag-eaton ektaghag-eaton added this to the 6.3.1 milestone Jul 31, 2024
@surajeaton surajeaton mentioned this issue Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected user-reported This was reported by a user outside the maintainers team.
Milestone
6.3.1
Development

No branches or pull requests
2 participants
@surajeaton @ektaghag-eaton